Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rsc): Set a yarn resolution for rollup 4.21.3 #11592

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix(rsc): Set a yarn resolution for rollup 4.21.3 #11592

merged 3 commits into from
Sep 20, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Sep 19, 2024 •
edited
Loading

Setting the resolution works around an issue we were seeing when trying to serve an RSC project

file:///Users/tobbe/tmp/rw-rollup/web/dist/ssr/assets/rsc-auth.ts-12-VjYFUfRl.mjs:820
if (Object$1.defineProperty.sham) defineProperty$5.sham = true;
             ^

TypeError: Cannot read properties of undefined (reading 'defineProperty')
    at file:///Users/tobbe/tmp/rw-rollup/web/dist/ssr/assets/rsc-auth.ts-12-VjYFUfRl.mjs:820:14
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
    at async createMiddlewareRouter (file:///Users/tobbe/tmp/rw-rollup/node_modules/@redwoodjs/vite/dist/middleware/register.js:57:69)
    at async runFeServer (file:///Users/tobbe/tmp/rw-rollup/node_modules/@redwoodjs/vite/dist/runFeServer.js:56:28)

Possibly related to rollup/rollup#5659

@Tobbe Tobbe added release:fix This PR is a fix experimental This PR relates to only experimental feature(s) labels Sep 19, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Sep 19, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label Sep 19, 2024
@Tobbe Tobbe force-pushed the tobbe-rsc-kitchen-sink-rollup-resolution branch from cae0c7a to dec38b8 Compare September 19, 2024 22:21
@Tobbe Tobbe merged commit 3fc9a45 into redwoodjs:main Sep 20, 2024
50 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-kitchen-sink-rollup-resolution branch September 20, 2024 06:46
@Tobbe Tobbe mentioned this pull request Sep 20, 2024
Closed
Tobbe added a commit to Tobbe/redwood that referenced this pull request Sep 23, 2024
@Tobbe
Revert "fix(rsc): Set a yarn resolution for rollup 4.21.3 (redwoodjs#…
063224c 
…11592)"

This reverts commit 3fc9a45.
Tobbe added a commit that referenced this pull request Sep 23, 2024
@Tobbe
Revert "fix(rsc): Set a yarn resolution for rollup 4.21.3 (#11592)" (#…
13b6df3 
…11600)
Josh-Walker-GM pushed a commit that referenced this pull request Sep 24, 2024
@Tobbe @Josh-Walker-GM
fix(rsc): Set a yarn resolution for rollup 4.21.3 (#11592)
ec84053
Josh-Walker-GM pushed a commit that referenced this pull request Sep 24, 2024
@Tobbe @Josh-Walker-GM
Revert "fix(rsc): Set a yarn resolution for rollup 4.21.3 (#11592)" (#…
05f301d 
…11600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check experimental This PR relates to only experimental feature(s) release:fix This PR is a fix
Projects
None yet
Milestone
v8.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM